Code quality

Author: wazabii8

.gitignore

@@ -1,3 +1,4 @@
 ._*
 .DS_Store
-.sass-cache
+.sass-cache
+vendor

Stream.php

@@ -24,14 +24,14 @@ class Stream implements StreamInterface
     private const READABLE_MATCH = '/r|a\+|ab\+|w\+|wb\+|x\+|xb\+|c\+|cb\+/';
     private const WRITABLE_MATCH = '/a|w|r\+|rb\+|rw|x|c/';
 
-    private $stream;
-    private $permission;
-    private $resource;
-    private $size;
-    private $meta = array();
-    private $readable;
-    private $writable;
-    private $seekable;
+    private mixed $stream;
+    private string $permission;
+    private mixed $resource;
+    private ?int $size = null;
+    private array $meta;
+    private bool $readable;
+    private bool $writable;
+    private bool $seekable;
 
     /**
      * PSR-7 Stream
@@ -47,11 +47,11 @@ public function __construct(mixed $stream = null, string $permission = "r+")
         if (is_resource($stream)) {
             $this->resource = $stream;
             $this->meta = $this->getMetadata();
-
-            if (is_null($this->meta)) {
-                throw new RuntimeException("Could not access the stream meta data.", 1);
+            /*
+             if (is_null($this->meta)) {
+                throw new RuntimeException("Could not access the stream metadata.", 1);
             }
-
+            */
             $this->stream = $this->meta['stream_type'];
             $this->permission = $this->meta['mode'];
         } else {
@@ -112,7 +112,7 @@ public function detach()
     }
 
     /**
-     * Returns whether or not the stream is seekable.
+     * Returns whether the stream is seekable.
      * @return bool
      */
     public function isSeekable(): bool
@@ -121,7 +121,7 @@ public function isSeekable(): bool
     }
 
     /**
-     * Returns whether or not the stream is writable.
+     * Returns whether the stream is writable.
      * @return bool
      */
     public function isWritable(): bool
@@ -130,7 +130,7 @@ public function isWritable(): bool
     }
 
     /**
-     * Returns whether or not the stream is readable.
+     * Returns whether the stream is readable.
      * @return bool
      */
     public function isReadable(): bool
@@ -159,14 +159,14 @@ public function stats(?string $key = null): mixed
     public function getSize(): ?int
     {
         $size = $this->stats('size');
-        $this->size = isset($size) ? $size : null;
+        $this->size = $size ?? null;
         return $this->size;
     }
 
     /**
      * Returns the current position of the file read/write pointer
      * @return int Position of the file pointer
-     * @throws \RuntimeException on error.
+     * @throws RuntimeException on error.
      */
     public function tell(): int
     {
@@ -189,7 +189,7 @@ public function getLine(): string|bool
      */
     public function eof(): bool
     {
-        return (is_resource($this->resource)) ? feof($this->resource) : true;
+        return !(is_resource($this->resource)) || feof($this->resource);
     }
 
     /**
@@ -210,24 +210,24 @@ public function clean(): void
      *     PHP $whence values for `fseek()`.  SEEK_SET: Set position equal to
      *     offset bytes SEEK_CUR: Set position to current location plus offset
      *     SEEK_END: Set position to end-of-stream plus offset.
-     * @throws \RuntimeException on failure.
+     * @throws RuntimeException on failure.
      */
     public function seek($offset, $whence = SEEK_SET): void
     {
         if ($this->isSeekable()) {
             fseek($this->resource, $offset, $whence);
         } else {
-            throw new RuntimeException("The stream \"{$this->stream} ({$this->permission})\" is not seekable!", 1);
+            throw new RuntimeException("The stream \"$this->stream ($this->permission)\" is not seekable!", 1);
         }
     }
 
     /**
      * Seek to the beginning of the stream.
      * If the stream is not seekable, this method will raise an exception;
      * otherwise, it will perform a seek(0).
+     * @throws RuntimeException on failure.
+     *@link http://www.php.net/manual/en/function.fseek.php
      * @see seek()
-     * @link http://www.php.net/manual/en/function.fseek.php
-     * @throws \RuntimeException on failure.
      */
     public function rewind(): void
     {
@@ -244,8 +244,7 @@ public function write(string $string): int
         if (is_null($this->size)) {
             $this->size = 0;
         }
-        $byte = fwrite($this->resource, $string);
-        return $byte;
+        return fwrite($this->resource, $string);
     }
 
     /**
@@ -264,7 +263,7 @@ public function read(int $length): string
     /**
      * Returns the remaining contents in a string
      * @return string
-     * @throws \RuntimeException if unable to read or an error occurs while reading.
+     * @throws RuntimeException if unable to read or an error occurs while reading.
      */
     public function getContents(): string
     {
@@ -276,7 +275,7 @@ public function getContents(): string
 
     /**
      * Get stream metadata as an associative array or retrieve a specific key.
-     * @param string $key Specific metadata to retrieve.
+     * @param string|null $key Specific metadata to retrieve.
      * @return array|mixed|null Returns an associative array
      */
     public function getMetadata(?string $key = null): mixed
@@ -305,7 +304,7 @@ public function withContext(array $opts): StreamInterface
      * Open a resource correct with the right resource
      * @param ...$fArgs
      * @return false|resource
-     * @throws \RuntimeException on error.
+     * @throws RuntimeException on error.
      */
     private function fopen(...$fArgs)
     {

tests/unitary-request.php

@@ -0,0 +1,36 @@
+<?php
+
+$unit = new MaplePHP\Unitary\Unit();
+
+
+$unit = new MaplePHP\Unitary\Unit();
+
+// If you build your library right it will become very easy to mock, like I have below.
+$request = new MaplePHP\Http\Request(
+    "POST", // The HTTP Method (GET, POST, PUT, DELETE, PATCH)
+    "https://admin:[email protected]:443/test.php?id=5221&place=stockholm", // The Request URI
+    ["Content-Type" => "application/x-www-form-urlencoded"], // Add Headers, empty array is allowed
+    ["email" => "[email protected]"] // Post data
+);
+
+// Begin by adding a test
+$unit->case("Checking data type", function() use($request) {
+
+    // Add a test, each test
+    $this->add($request->getMethod(), function() {
+
+        return $this->equal("POST");
+
+    }, "HTTP Request method Type is not POST");
+
+    $this->add("ww", [
+        "isInt" => [],
+        "max" => [65535],
+    ], "Is not a valid port number");
+
+
+});
+
+echo "ww";
+
+$unit->execute();