`SurroundingRectangle` too tall when surrounding `code_lines`

[emilyrhee]

Description of bug / unexpected behavior

The first and third SurroundingRectangle in the image below is way taller than the second one. The issue of it being too tall seems to arise only when there is leading whitespace in a line of code.

Expected behavior

I expect every SurroundingRectangle to have the height of the one on line 5 of the image.

How to reproduce the issue

Code for reproducing the problem

Driver code:

from manim import *

class Test(Scene):
    def construct(self):
        code = Code("test.py", language="python")

        self.add(
            code, 
            SurroundingRectangle(code.code_lines[1]),
            SurroundingRectangle(code.code_lines[4]),
            SurroundingRectangle(code.code_lines[8])
        )

test.py:

def foo():
    print("bar")
    print("foobar")

def bar():
    print("foo")

for number in range(1, 9):
    print(number)

Additional media files

[OliverStrait]

This is caused by Dot mobject that is created to represent spaces in text. Center point of those Dots are moved to last actual character.
When there is newline and it starts with spaces, last character is in last line and Dot is moved into it (This can be observed in images of surrounding rectangle)

manim/manim/mobject/text/text_mobject.py

Line 623 in 48d5a36

self.submobjects[submobjects_char_index - 1].get_center(),

• Quick fix would be to just remove dots in end of initation of Code after those are not needed anymore.
• or to Made system in Text that can handle newlines and put those center points in same line..

[behackl]

Thanks, I actually investigated this for a little while yesterday and came to the same conclusion. I'll prepare a patch removing the Dot mobjects from the individual paragraph lines. (A cleaner implementation of Paragraph would be nice too, but it sort of out of scope right now.)