You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
It seems DetectMarkers has not the same behavior between the original C++ and this Python wrapper : convertToTuple applies a cast to int that is not present in the C++ library : std::vector<std::vector<float>> contours_vec; for (cv::Point2f pt : corners[i]) { contours_vec.push_back({static_cast<float>((int)pt.x), static_cast<float>((int)pt.y)}); }
Is this type cast to int necessary between float and Point2f ? The accuracy pointed out in the original paper must be downgraded by this step.
The text was updated successfully, but these errors were encountered:
Hi,
as mentioned in this issue, I honestly can't recall the exact reason why I originally clipped the values to integers. I tested it without clipping and had no problems. If you'd like, I can build and distribute a new version without the casting.
Hi,
That would be great, I had some issues compiling locally. I am interested too by the full resolution of the output for a Python testbed, if only to see if I can improve positioning results compared to regular subPixelCorners applied after the fact. Thanks !
Best regards
Hi,
It seems DetectMarkers has not the same behavior between the original C++ and this Python wrapper : convertToTuple applies a cast to int that is not present in the C++ library :
std::vector<std::vector<float>> contours_vec; for (cv::Point2f pt : corners[i]) { contours_vec.push_back({static_cast<float>((int)pt.x), static_cast<float>((int)pt.y)}); }
Is this type cast to int necessary between float and Point2f ? The accuracy pointed out in the original paper must be downgraded by this step.
The text was updated successfully, but these errors were encountered: