axis = (; xlabelvisible = false) doesn't work if mapping.col is used

[vladdez]

Bug description

axis = (; xlabelvisible = false) doesn't work if mapping.col is used

Steps to reproduce

using Unfold, UnfoldMakie, AlgebraOfGraphics
m = example_data("UnfoldLinearModel")
results = coeftable(m)


plot_erp(results; axis = (; xlabelvisible = false, xticklabelsvisible = false)) #works
plot_erp(
        results;
        mapping = (; col = :coefname),
        axis = (;
            xlabel = "test",
            titlevisible = false,
            xlabelvisible = false,
            ylabelvisible = false,
            yticklabelsvisible = false,
            xticklabelsvisible = false,
        ),
) #not working

Images

Version info

Julia Version 1.10.0
Commit 3120989f39b (2023-12-25 18:01 UTC)
Build Info:
Official https://julialang.org/ release
Platform Info:
OS: Linux (x86_64-linux-gnu)
CPU: 128 × AMD EPYC 7452 32-Core Processor
WORD_SIZE: 64
LIBM: libopenlibm
LLVM: libLLVM-15.0.7 (ORCJIT, znver2)
Threads: 1 on 128 virtual cores
Environment:
JULIA_EDITOR = code
JULIA_NUM_THREADS =
JULIA_DEBUG = UnfoldMakie

AlgebraOfGraphics v0.8.7
CairoMakie v0.12.9

[jkrumbiegel]

Hm that doesn't work because the label is not an axis xlabel but a separate Label that's drawn in a similar position (but can also sit between axes). I'm not sure it makes sense to pretend like xlabelvisible should affect that.

[behinger]

So in AoG, if you have faceting, how would you change the label of individual axes? Aka, how to access that label/property?

[jkrumbiegel]

What do you mean by "individual axes"? Usually in facetting, if the same label appears under every axis, they're merged. The label is the one passed in the mapping usually, like mapping(:x => "x label")

[jkrumbiegel]

Going to close this one as the canonical ways in Makie to hide the x label are either :x => "" or scales(X = (; label ="")) and the axis properties should only be used for the less "semantic" things like tick label rotation etc. Otherwise you're going to collide with implementation details like how the shared x label is made with a Label.