Fix logging in write_netcdf()#643
Merged
Merged
Conversation
xylar
force-pushed
the
fix-write-netcdf-logging
branch
from
eedde52 to
1687d78
Compare
Collaborator
Author
TestingI was able to run test with my polaris branch https://github.com/xylar/polaris/tree/add-cull-topo, whereas those runs failed without this fix. |
xylar
added a commit
to xylar/polaris
that referenced
this pull request
Jun 16, 2025
This version of MPAS-Tools has a bug fix (MPAS-Dev/MPAS-Tools#643) that we need.
xylar
added a commit
to xylar/polaris
that referenced
this pull request
Jun 16, 2025
This version of MPAS-Tools has a bug fix (MPAS-Dev/MPAS-Tools#643) that we need.
xylar
added a commit
to xylar/polaris
that referenced
this pull request
Jun 23, 2025
This version of MPAS-Tools has a bug fix (MPAS-Dev/MPAS-Tools#643) that we need.
xylar
added a commit
to xylar/polaris
that referenced
this pull request
Aug 14, 2025
This version of MPAS-Tools has a bug fix (MPAS-Dev/MPAS-Tools#643) that we need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes enhancements to the
write_netcdffunction and its associated tests, focusing on improved handling of arguments and logging functionality. The changes ensure compatibility withPathobjects and integrate a logging context into the testing framework.Enhancements to
write_netcdffunction:conda_package/mpas_tools/io.py: Added a conversion step to ensure all arguments passed to the subprocess are strings, improving compatibility withPathobjects.Updates to test framework:
conda_package/tests/test_io.py: Modifiedtest_write_netcdf_cdf5_formatto use a logging context, passing the logger to thewrite_netcdffunction for better traceability during testing and testing of logging capability.