Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samurai Ikishoten #352

Open
QuoteXV opened this issue Aug 25, 2024 · 4 comments
Open

Samurai Ikishoten #352

QuoteXV opened this issue Aug 25, 2024 · 4 comments

Comments

@QuoteXV
Copy link

QuoteXV commented Aug 25, 2024

Does Ikishoten not turn into Ogi Namikiri and Kaeshi: Namikiri anymore?

@mkirk413
Copy link

I noticed this today as well. This was working in Skooz'z fork.

@mkirk413
Copy link

mkirk413 commented Aug 30, 2024

Actually, I played around with this a little bit more. Ikishoten grants BOTH Zanshin Ready and Ogi Namikiri Ready. Additionally, Zanshin and Ogi Namikiri do not share a cool down and SE made it so you can map Zanshin to Ikishoten. So from that stand point, you would have Ikishoten->Zanshin one one button and Ogi Namikiri->Kaeshi: Namikiri on another.

Edit to add TL:DR not broken

@Skooz
Copy link
Contributor

Skooz commented Aug 30, 2024

It was removed because of Zanshin. Same deal for War's Inner Release and Primal Rend. Having the option interferes with player choice; the code would have to prioritize one ability over the other.

In most cases with XIVCombo, the code will choose the logical braindead choice, like the next step in a 123 combo.

However, there's no obvious choice between these two abilities; there is no intended sequence for them to be used in, other than looking up a rotation online. Thus, enabling the combo would hinder your flexibility while playing; if the combo prioritizes Zanshin, what do you do if you want to use Ogi Namikiri first? It could also be seen as rotation automation, as the code is technically making an intelligent decision for you, even if it's not a big one.

IMO it's not a big deal, since Shoha got condensed into one button; I just put Ogi where the AoE Shoha used to be.

@mkirk413
Copy link

IMO it's not a big deal, since Shoha got condensed into one button; I just put Ogi where the AoE Shoha used to be.

This

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants