Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Alternate Draw replacement for AST #343

Open
demonsdawn opened this issue Aug 12, 2024 · 5 comments
Open

[suggestion] Alternate Draw replacement for AST #343

demonsdawn opened this issue Aug 12, 2024 · 5 comments

Comments

@demonsdawn
Copy link

demonsdawn commented Aug 12, 2024

What is thy suggestion?
Alternative option to replace Draw with Minor Arcana when cards are drawn.

1) Are abilities in question must be truly mutually exclusive?
Yesn't
Case A) When you do not play your Minor Arcana before you wish to redraw, in which case would lose the card anyway, you would have to press the button twice.
Case B) With how the new draw system works, you'd have to disable this combo pre-70(or before you finish the class quest). Currently the game will always draw a Minor Arcana, even if you do not have access to them yet, which would lock up the entire card system. (its weird, i know)

2) Does this actually saves you button space?
1 button, same as the current option (but less ugly imo)

3) Is it wild and wacky?
About as wild as watching paint dry.

4) Is the overall level of intelligence required to execute is about as low as the floor?
Even a Warrior main could figure this out.

Side Note
Made this same suggestion for Skooz's Fork while the main was still being worked on, it works perfectly.

@Alluneve
Copy link

You neatly explained why this wouldn't work:

  • bricks when level-synced below 70
  • you've become unable to redraw while you have a minor arcana active (this can and does happen in optimised play, rarely you just throw away the ladies minor arcana)

DENIED

@Skooz
Copy link
Contributor

Skooz commented Sep 11, 2024

bricks when level-synced below 70

That's why you include a level check.

if (actionID == AST.MinorArcana)
{
    var x = iconHook.Original(self, actionID);
    if (x != AST.MinorArcana && level >= 70) 
        return x;
    return iconHook.Original(self, AST.AstralDraw);
}

you've become unable to redraw while you have a minor arcana active

You shouldn't be holding it for that long anyway, so it's a moot point.

@Alluneve
Copy link

the XivCombo plugin has some self-imposed rules:
the first is that it cannot have a brain no smart thinking and 2 if you COULD do something and that something is a valid action, then it should be able to be done.

holding on Lady of Crowns is a perfectly valid thing to do, and it's zero dps loss if you somehow do not use it, thus you should be able to throw away Lady of crowns with an Astral draw.

your suggestion enacts FORCED play and even forced un-optimal play, with a forced delay on the redraw action by one gcd or clipped gcd if you happened to have your lady of crowns still.

DENIED

@Skooz
Copy link
Contributor

Skooz commented Sep 11, 2024

your suggestion enacts FORCED play

So you didn't actually bother to read my code, lol.

It replaces Minor Arcana with Draw. You can still use Draw if it's on your hotbar, and drop Minor Aracana. The decision of whether or not to take Draw entirely off your hotbars is up to you.

with a forced delay on the redraw action by one gcd or clipped gcd if you happened to have your lady of crowns still.

So, technically this is already true of the current implementation if you're removing draw from your hotbar.

@demonsdawn
Copy link
Author

demonsdawn commented Sep 11, 2024

your suggestion enacts FORCED play and even forced un-optimal play, with a forced delay on the redraw action by one gcd or clipped gcd if you happened to have your lady of crowns still.

That would be a fair point if the current solution didn't also block you from drawing cards unless you use at least 1 of them first.
(unless you keep the baseline draw on your hot bar of course, kinda beats the purpose.)

Now i will concede that losing out on your basic cards is far less likely of a scenario to pop up. But my point is, both the current and the suggested alternative suffer from this "drawback". It seems pedantic to distinguish between them based on a margin of error that amounts to less than the average miss-click. (which mind you, the current solution does not prevent you from accidentally miss-clicking and losing all your cards, even with the safety delay.)

Additionally, i did bring this up as a mutual alternative, not a replacement. People already have the option to not use certain combos if it would interfere with their gameplay one way or another, personal preference and all that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants