Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Upload zip extract import #2562

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Oct 17, 2024

Add support of upload of single zip files.

⚠️ this is quite experimental, I tested locally that it works, however there are some caveats to know about.

  1. The uploaded zip file will stay on your server unless it is properly extracted without faults (after which it is removed).
  2. Similarly the extracted files from the zip will stay on your server unless they are properly imported without fault.
  3. On import success, you will see in /path-to-lychee/storage/extract-jobs an empty folder prefixed with YmD so you know when it was created, making easier to clean up later.
  4. ONLY THE FIRST LEVEL OF THE ZIP IS IMPORTED. See explanation below.

In other words, if you have

Something_Stupid.zip
├── img1.jpg
├── img2.jpg
├── img3.jpg
└── SubFolder
    ├── img4.jpg
    ├── img5.jpg
    └── img6.jpg

Only img1.jpg, img2.jpg and img3.jpg will be imported in Something Stupid album (note that _ is automatically replaced by space) and deleted from /path-to-lychee/storage/extract-jobs/yyyymmddSomething_Stupid.
The folder SubFolder will still be in /path-to-lychee/storage/extract-jobs/yyyymmddSomething_Stupid/SubFolder

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 86 lines in your changes missing coverage. Please review.

Project coverage is 84.12%. Comparing base (b156ec4) to head (30350d1).

Additional details and impacted files

Base automatically changed from v6 to master October 26, 2024 10:41
@ildyria ildyria force-pushed the upload-zip-extract-import branch from eb189ca to 30350d1 Compare October 26, 2024 10:54
@ildyria ildyria changed the title ⚠️ WIP - Upload zip extract import 🚧 Upload zip extract import Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant