Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Add Guid array to metadata response #16

Open
fredodiable opened this issue Mar 23, 2024 · 5 comments
Open

[enhancement] Add Guid array to metadata response #16

fredodiable opened this issue Mar 23, 2024 · 5 comments

Comments

@fredodiable
Copy link

fredodiable commented Mar 23, 2024

Can you add the Guid array in response
I need these to interact with others services like TMDB API
Example (next to Genre and Role)

"Guid": [
  {
    "id": "imdb://tt3359350"
  },
  {
    "id": "tmdb://359410"
  },
  {
    "id": "tvdb://352454"
  }
],

Thanks in advance

@fredodiable fredodiable changed the title Add Guid array to response Add Guid array to metadata response Mar 23, 2024
@fredodiable fredodiable changed the title Add Guid array to metadata response [enhancement] Add Guid array to metadata response Mar 23, 2024
@LukeHagar
Copy link
Owner

Hey @fredodiable,

So if I recall correctly there is actually a collision here, as the plex response has two keys with the same value, but are different cases.
In the specification I overrode the value here

@fredodiable
Copy link
Author

Unfortunaly, the guids and ratings array are not presents in the response
Maybe the name override isn't working properly ?

image

@Funtime60
Copy link

Should this be closed? I have the array guids when I use the SDK. Or maybe you're waiting to change it to match the webhook payload which uses Guid?

@fredodiable
Copy link
Author

Sorry I moved to another library some months ago (plex-sdk)
So I'm not able to test this anymore
If you can now see the guids with latest version using typescript or javascript, yes the issue can be closed
The response key name doesn't matter, the code would use whatever it is :)

@Funtime60
Copy link

Sorry for bothering you, was mostly addressing the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants