Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ISession.FlushAsync() instead of SaveChangesAsync() (OSOE-1037) #149

Open
Piedone opened this issue Feb 25, 2025 · 0 comments
Open

Use ISession.FlushAsync() instead of SaveChangesAsync() (OSOE-1037) #149

Piedone opened this issue Feb 25, 2025 · 0 comments

Comments

@Piedone
Copy link
Member

Piedone commented Feb 25, 2025 •
edited
Loading

Here:

Hosting-Tenants/Lombiq.Hosting.Tenants.Maintenance/Services/MaintenanceManager.cs

Line 116 in 4912cfa

await _session.SaveChangesAsync();
For the reason see OrchardCMS/OrchardCore#17084 (comment).

Check if the feature still works and it indeed doesn't need SaveChangesAsync(), even in the ReloadShellAfterMaintenanceCompletion case.

Related: Lombiq/Helpful-Libraries#319.

Jira issue
@Piedone Piedone mentioned this issue Feb 25, 2025
Open
@github-actions github-actions bot changed the title Use ISession.FlushAsync() instead of SaveChangesAsync() Use ISession.FlushAsync() instead of SaveChangesAsync() (OSOE-1037) Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Piedone