Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Vue 2 compact with vue-demi #4

Open
imrim12 opened this issue Nov 8, 2022 · 1 comment
Open

[Feature request] Vue 2 compact with vue-demi #4

imrim12 opened this issue Nov 8, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@imrim12
Copy link

imrim12 commented Nov 8, 2022

This is a very cool package but I think Vue 2 compact support is one of the big reasons to use it for some legacy projects which are slowly being migrated to Vue 2.7 or Vue 3
I see this part in the package.json and no Vue 2.x support, would we ever consider doing this?

All the import use: import ... from 'vue', i think vue-demi would be great for this instead, what do you think?

...
    "vue": "^3.2.41",
    "vue-tsc": "^1.0.8"
  },
  "peerDependencies": {
    "vue": "^3.2"
  },
...
prd-y-nguyen added a commit to prd-y-nguyen/vue-mixable that referenced this issue Nov 8, 2022
@LinusBorg
Copy link
Owner

I'll consider this, but worry it might be quite a hassle to implement on the Typescript side.

Concerning a migration though, my Thought process was that a migration from mixins to composables was something I would do step by step after I moved to Vue 3. But sure, there might be scenarios where one might want to do this before the actual migration

@LinusBorg LinusBorg added the enhancement New feature or request label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants