You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello there,
I was reading through your code (currently looking at sefr.py) and noticed that in some places the kernel type is checked even though the subsequent code is identical regardless of the condition. For example, on line 261:
Both branches of the conditional execute the same code.
Similarly, in the _check_X_y method, it seems possible to move the kernel check to after X and y are set. Or in the _check_X method, the kernel check might also be deferred until after the hasattr() function call.
Is there a specific reason for doing it this way, for example, to support a planned feature in the future that might need the separation? also, are you currently open to pull requests for improvements like this?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Hello there,
I was reading through your code (currently looking at sefr.py) and noticed that in some places the kernel type is checked even though the subsequent code is identical regardless of the condition. For example, on line 261:
Both branches of the conditional execute the same code.
Similarly, in the
_check_X_y
method, it seems possible to move the kernel check to afterX
andy
are set. Or in the_check_X
method, the kernel check might also be deferred until after thehasattr()
function call.Is there a specific reason for doing it this way, for example, to support a planned feature in the future that might need the separation? also, are you currently open to pull requests for improvements like this?
Beta Was this translation helpful? Give feedback.
All reactions