Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global & Special Loggers #20634

Open
jamie-mcg opened this issue Mar 11, 2025 · 0 comments
Open

Global & Special Loggers #20634

jamie-mcg opened this issue Mar 11, 2025 · 0 comments
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers

Comments

@jamie-mcg
Copy link

jamie-mcg commented Mar 11, 2025

Description & Motivation

The trainer currently treats all loggers the same, meaning that if you design a custom logger for a specific purpose, it gets called every time self.log is called. This means if I have two separate CSVLogger's defined, one for normal training metrics and another for some non-standard metrics that do not fit with the 1st loggers schema, then PL will still attempt to log all metrics to both CSVLoggers.

It would be nice to have the ability to separate Global loggers (i.e. ones that should be activated with self.log) and those which are more specific to an independent purpose.

Pitch

I believe it can be done fairly easily by allowing for a separate logger-type list to be added to the Trainer class (i.e. logger_others (or some better name...), then the LoggerConnector class can simply configure the two separately.

Alternatives

I think the only alternative is to instantiate a separate logger class within the Callback? But this has all sorts of integration issues that you need to do to get it to work with the trainer.

Additional context

Very happy to open a PR with a proposed solution for this.

cc @lantiga @Borda

@jamie-mcg jamie-mcg added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers
Projects
None yet
Development

No branches or pull requests

1 participant