Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fabric.save docs/examples are wrong for latest version #20622

Open
ppisljar opened this issue Mar 6, 2025 · 0 comments
Open

fabric.save docs/examples are wrong for latest version #20622

ppisljar opened this issue Mar 6, 2025 · 0 comments
Labels
docs Documentation related needs triage Waiting to be triaged by maintainers

Comments

@ppisljar
Copy link

ppisljar commented Mar 6, 2025

📚 Documentation

all docs seem to mention that fabric.save should be called with
fabric.save(model.to_state_dict(), checkpoint_path) but it seems that in latest version the params have been switched and checkpoint_path needs to be passed first

example doc: https://lightning.ai/docs/pytorch/LTS/fabric/api/fabric_methods.html

cc @lantiga @Borda

@ppisljar ppisljar added docs Documentation related needs triage Waiting to be triaged by maintainers labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related needs triage Waiting to be triaged by maintainers
Projects
None yet
Development

No branches or pull requests

1 participant