Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump transformers to 4.49 #1968

Open
ysjprojects opened this issue Mar 14, 2025 · 1 comment · May be fixed by #1969
Open

Bump transformers to 4.49 #1968

ysjprojects opened this issue Mar 14, 2025 · 1 comment · May be fixed by #1969
Labels
enhancement New feature or request

Comments

@ysjprojects
Copy link
Contributor

https://huggingface.co/microsoft/Phi-4-mini-instruct/discussions/1

A phi-4-mini-instruct bug is fixed in transformers 4.49. However, the changes are not backward compatible, so to support phi-4-mini-instruct we may have to bump our transformers version to 4.49.

How feasible would it be to bump up the version currently? And which part of the codebase should we be wary of that may potentially break from this version bump?
@ysjprojects ysjprojects added the enhancement New feature or request label Mar 14, 2025
@craigpfeifer
Copy link

It would be easy to test by creating a branch and changing the version of transformers to 4.49.x in the dependencies and then see if the tests pass. If they do pass, then there's likely no impact.

@craigpfeifer craigpfeifer linked a pull request Mar 16, 2025 that will close this issue
wip : increment transformers to 4.49 #1969
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wip : increment transformers to 4.49 Lightning-AI/litgpt
2 participants
@craigpfeifer @ysjprojects