Init Implementation per_stream batching
#438
Conversation
for more information, see https://pre-commit.ci
…data into per_stream_batching
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@tchaton When is the I'm trying to send messages to iterators and process them within their worker loops -- when the iterator must change it's dataset index (i.e., on batch boundaries). I'm getting confused by the difference between |
Borda
changed the title
per_stream batching
| for batch in super().__iter__(): | ||
| print("Fetched a batch ...") |
There was a problem hiding this comment.
maybe use loggier instead of print
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #438 +/- ##
===================================
- Coverage 78% 78% -0%
===================================
Files 35 35
Lines 5106 5141 +35
===================================
+ Hits 4006 4024 +18
- Misses 1100 1117 +17 |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 5685611 | Triggered | Generic High Entropy Secret | 7cf1b41 | tests/streaming/test_resolver.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Before submitting
What does this PR do?
Fixes #434
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃