Use context manager to set priority for the sdp attention backends #1715
+34
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Let's make this an option to enable or disable cuDNN SDPA for eager and torch.compile for easier switch in the future.
There was a problem hiding this comment.
Done, although need to add a condition to skip for Thunder. Will let you know once done
riccardofelluga
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Same error as reported in #1714 happens here, this needs more investigation.
riccardofelluga
requested changes
Jan 30, 2025
Co-authored-by: Riccardo Felluga <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
riccardofelluga
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #1714.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃