New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ThunderModule.no_sync behave as PyTorch's Distributed one #1670

Open

t-vi opened this issue Jan 21, 2025 · 0 comments

Collaborator

t-vi commented Jan 21, 2025

Currently, we force sync upon exiting the context manager.
This is different to the PyTorch behaviour which syncs at the next call without no-sync.

To enhance compatibility, we should keep this accounting on the ThunderModule (which was not there when we initially implemented no_sync).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment