Skip to content

Commit ebe1cb7

Browse files
committed
chore: reduce mocks
Signed-off-by: Vitor Mattos <[email protected]>
1 parent 2916728 commit ebe1cb7

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

tests/Unit/Handler/Pkcs12HandlerTest.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ final class Pkcs12HandlerTest extends \OCA\Libresign\Tests\Unit\TestCase {
2727
private SystemConfig $systemConfig;
2828
private IL10N $l10n;
2929
private JSignPdfHandler&MockObject $jSignPdfHandler;
30-
private FooterHandler&MockObject $footerHandler;
30+
private FooterHandler $footerHandler;
3131
private ITempManager $tempManager;
32-
private CertificateEngineHandler&MockObject $certificateEngineHandler;
32+
private CertificateEngineHandler $certificateEngineHandler;
3333

3434
public function setUp(): void {
3535
$this->folderService = $this->createMock(FolderService::class);
@@ -38,11 +38,10 @@ public function setUp(): void {
3838
\OCP\Server::get(\Psr\Log\LoggerInterface::class),
3939
\OCP\Server::get(\OCP\Security\ICrypto::class),
4040
);
41-
$this->systemConfig = $this->createMock(SystemConfig::class);
42-
$this->certificateEngineHandler = $this->createMock(CertificateEngineHandler::class);
41+
$this->certificateEngineHandler = \OCP\Server::get(CertificateEngineHandler::class);
4342
$this->l10n = \OCP\Server::get(IL10NFactory::class)->get(Application::APP_ID);
4443
$this->jSignPdfHandler = $this->createMock(JSignPdfHandler::class);
45-
$this->footerHandler = $this->createMock(FooterHandler::class);
44+
$this->footerHandler = \OCP\Server::get(FooterHandler::class);
4645
$this->tempManager = \OCP\Server::get(ITempManager::class);
4746
}
4847

@@ -60,7 +59,7 @@ private function getHandler(): Pkcs12Handler {
6059
}
6160

6261
public function testSavePfxWhenPfxFileIsAFolder():void {
63-
$node = $this->createMock(\OCP\Files\Folder::class);
62+
$node = \OCP\Server::get(\OCP\Files\Folder::class);
6463
$node->method('nodeExists')->will($this->returnValue(true));
6564
$node->method('get')->will($this->returnValue($node));
6665
$this->folderService->method('getFolder')->will($this->returnValue($node));

0 commit comments

Comments
 (0)