Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next / Previous buttons on Patient Finder do not change display #1412

Open
tusharjindal100 opened this issue Mar 1, 2019 · 11 comments · May be fixed by #1541
Open

Next / Previous buttons on Patient Finder do not change display #1412

tusharjindal100 opened this issue Mar 1, 2019 · 11 comments · May be fixed by #1541
Labels
outreachy For outreachy issues and bug hunts UI: Layout

Comments

@tusharjindal100
Copy link

tusharjindal100 commented Mar 1, 2019

A) My Outreachy username : Jindal_Tushar

B) Issue Title : Next / Previous buttons on Patient Finder do not change display

C) Bug Report Date : 27 FEB 2019

D) Site Affected : Documentation Site.

E) OS/Browser Used : MacOS/Chrome

F) Module/Tab : Patient Finder

G) Step to reproduce:
1. Login with your account credentials.
2. Take your cursor to Patient/Client tab then you see the Finder.Click on it.
3. You will see Previous and Next button at the bottom of the tab.
4. Click on the Next/Previous button.

H) Expected Behavior : Next/Previous buttons should change the display in Patient Finder. If one screen shows 10 results of patients then Next button should show the next 10 results on the screen and Previous button should show the previous 10 results.

I) What actually Happened : I am not able to click Next/Previous Button on Patient Finder.

J) ScreenShots:
Patient Finder

image

K) Estimation of the bug severity: Work with Workaround

L) Workaround:
For Developers :-
Div of the Orange(Refresh) button below the Previous/Next Button is so large that it is covering the Previous/Next button. We can decrease the size of the Div. I am attaching the Chrome Inspector so that it would be easy to solve this bug.

image

For Users/Healthcare professional:-
For accessing the button, Make sure that the Patient Finder tab is presented on the left side of screen with at least one tab is opened at the right of it. (See the screenshot below)

image

@aethelwulffe
Copy link
Contributor

I notice that the documentation site (from your screenshots) has the updater icon on, and I am not sure about the theme. These are factors that may affect this. My instances all work. Then again, I don't use less than a 1080p screen, and there can be scaling issues affecting the use case.
This needs to get hardened in any case. Please request assignment to fix this issue.

@KoniKodes
Copy link
Contributor

Thank you. This was found and reported by our Outreachy EHR Coder Intern Candidate.
Is it possible to request a dev to help the candidate learn to fix it?

@aethelwulffe
Copy link
Contributor

I believe it is due to the documentation site's settings (bad theme), but I will try to replicate the issue more closely so that I may advise the candidate @tusharjindal100 (welcome aboard!).

@KoniKodes
Copy link
Contributor

Thank you so much!

@muarachmann
Copy link
Member

@aethelwulffe i will get rid of the updater icon if you want and let the outreach applicant do the fix. I kinna wanted a newbie to fix this here #1400 @KoniKodes i am available if any. I love the way the stuff is explained maybe i should build some template for reporting issues after outreachy's round

@KoniKodes
Copy link
Contributor

Thank you @muarachmann If it is approved, I know my applicant would appreciate it.

@htuck created the Report Template, I just added a couple of thoughts after everything else was in place. I'm sure he won't mind sharing if you ask nicely, it's all for the same EHR team.

Yes, I will be calling on you for guidance.

@muarachmann muarachmann added outreachy For outreachy issues and bug hunts UI: Layout labels Mar 5, 2019
@muarachmann
Copy link
Member

@KoniKodes like i said i have the next and prev stuffs working. The issue should rather be removing the updater that blocks #1400 or something similar take a look i have 51-100 entries i am looking at right now when i press next

screen shot 2019-03-08 at 6 16 37 pm

@muarachmann
Copy link
Member

@tusharjindal100 are you still on this ?

@KoniKodes
Copy link
Contributor

KoniKodes commented Mar 8, 2019

He is currently in the hospital. We are sending best wishes that he can join us soon.

If he's not back in time, will you work with the chosen intern to fix this?

Otherwise you can work together when he returns.

@tusharjindal100
Copy link
Author

@muarachmann I am back.Pleade tell me what to do about this.Will be more than happy to contribute

@muarachmann
Copy link
Member

muarachmann commented Mar 12, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy For outreachy issues and bug hunts UI: Layout
Projects
None yet
4 participants