/embed and /embed-upload report success when storage fails (silent data loss) #305

Summary

POST /local/embed and POST /embed-upload return {"status": true} / HTTP 200 even when the embedding/insertion step failed and nothing was persisted — silent data loss.

Root cause

store_data_in_vector_db always returns a dict, with an "error" key on failure:

return {"message": "Documents added successfully", "ids": ids}            # success
...
return {"message": "An error occurred while adding documents.", "error": str(e)}  # failure

But the callers only test the dict's truthiness:

# embed_local_file
if result:                 # a failure dict is still truthy
    return {"status": True, ...}

# embed_file_upload
if not result:             # a failure dict is never falsy
    raise HTTPException(500, ...)

So a failure dict passes both checks and the endpoints report success. (POST /embed already inspects "error" and is not affected.)

Impact

The client (e.g. LibreChat) marks the file as successfully indexed, but later queries return nothing — confusing, silent data loss with no error surfaced.

Fix

Inspect the result for an "error" key (or a falsy value) in both endpoints and raise HTTP 500 with the error detail, matching what /embed already does. PR to follow.