Repository navigation
Commit 76192bd
authored
🛂 feat: Audit Resource Sharing Changes and Fail Closed on Reversible Audit Writes (#17053)
* feat: Audit Resource ACL Changes and Fail Closed by Default
* fix: Keep Non-Reversible Admin Audit Handlers Fail-Open
* docs: Narrow AUDIT_LOG_FAIL_CLOSED Description
* fix: Audit and Restore ACL and Insights Changes in One Pass
* fix: Break Audit and Insights Permission Type Cycle
* test: Cover Resource ACL Audit Scenarios
* refactor: Audit Resource Permission Changes Before Writing
* test: Align Concurrent Revoke Audit Expectation
* fix: Skip Deleting ACL Entries That Were Not Audited
* fix: Read ACL Snapshots Through the Write Session
* fix: Never Block Revocations on Audit Outages and Normalize Principal Keys
* fix: Let an Explicit Public Disable Win Over a Public Update
* fix: Audit Duplicate ACL Rows as Combined Permissions
* fix: Audit Permission Changes Under One Target and Dedupe Revokes
* fix: Audit Capability Grants Before Writing Them
* feat: Serialize Resource Permission Updates With a Per-Resource Lease
* fix: Fence the Resource Lease Before Writes and Always Audit Grant Assignments
* fix: Renew the Resource Lease Before Each ACL Write Phase
* fix: Serialize System Grant Assignment and Revocation With a Per-Grant Lease
* fix: Keep Leases Alive During Audits, Bound Lock Index Wait, Canonicalize Audit Target IDs
* fix: Retry Deferred Revoke Audits Under the Lease and Audit Canonical Principal and Role IDs
* test: Expect Role IDs in Permission Audit Metadata
* fix: Read Mutation Snapshots From the Primary Outside Transactions
* fix: Flush Deferred Audits Before Cache Invalidation, Keep Renewals Monotonic, Keep Role Case in Grant Lease Keys
* refactor: Map the Busy Permission Error to Its Code in the API Package
* style: Sort Lease Imports and Type the Renewal Spec Read
* fix: Keep Success Audits After Commit, Report Downgrades as Revocations, Code Audit Outages
* refactor: Move the Audit Outage Code to Its Own Module
* fix: Translate Lock Failures, Lease Non-Transactional Sessions, and Code Grant Audit Outages
* fix: Sanitize Lease Renewal Failures at the Permission Boundary
* fix: Annotate the Unavailable Error Code for Isolated Declarations
* fix: Keep the Admin Route Fail-Closed Opt-In and Document Lease Clock Skew Safety
* fix: Translate Grant Lease Store Failures to a Retryable 503
* fix: Log Failed Grant Audit Writes With Safe Metadata Only
* test: Detect Raw Error Arguments in the Grant Audit Log Spec
* feat: Make Permission Lease Limits Configurable and Localize Retryable Sharing Failures
* fix: Bound Lock Index Readiness by the Lease Wait and Carry the Resource ID in Every Audit Entry
* test: Cover Lease Config Reaching the Leases and the Sharing Dialog Failure Messages
* fix: Load App Config on the Sharing and Grant Routes and Log Failed Lease Releases
* perf: Load App Config Only on the Grant Mutation Routes1 parent ccae5b9 commit 76192bd
46 files changed
Lines changed: 2836 additions & 849 deletions
File tree
- api/server
- controllers
- __tests__
- routes
- admin
- services
- client/src
- components/Sharing
- __tests__
- locales/en
- docs/permissions
- e2e/specs/mock/scenarios
- packages
- api/src
- acl
- admin
- data-provider/src
- data-schemas/src
- methods
- models
- schema
- types
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
180 | 191 | | |
181 | 192 | | |
182 | 193 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
20 | | - | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
| 173 | + | |
183 | 174 | | |
| 175 | + | |
184 | 176 | | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
198 | 191 | | |
199 | 192 | | |
200 | 193 | | |
| |||
238 | 231 | | |
239 | 232 | | |
240 | 233 | | |
| 234 | + | |
241 | 235 | | |
242 | 236 | | |
243 | 237 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | 36 | | |
38 | 37 | | |
39 | | - | |
40 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
41 | 47 | | |
42 | 48 | | |
43 | 49 | | |
| |||
249 | 255 | | |
250 | 256 | | |
251 | 257 | | |
252 | | - | |
253 | 258 | | |
254 | 259 | | |
255 | 260 | | |
| |||
339 | 344 | | |
340 | 345 | | |
341 | 346 | | |
342 | | - | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
343 | 350 | | |
344 | 351 | | |
345 | 352 | | |
346 | | - | |
| 353 | + | |
347 | 354 | | |
348 | 355 | | |
349 | 356 | | |
350 | 357 | | |
351 | 358 | | |
352 | 359 | | |
353 | | - | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
354 | 364 | | |
355 | | - | |
| 365 | + | |
356 | 366 | | |
357 | 367 | | |
358 | 368 | | |
359 | 369 | | |
360 | 370 | | |
361 | 371 | | |
362 | 372 | | |
363 | | - | |
| 373 | + | |
364 | 374 | | |
365 | 375 | | |
366 | 376 | | |
| |||
390 | 400 | | |
391 | 401 | | |
392 | 402 | | |
393 | | - | |
394 | | - | |
395 | | - | |
396 | | - | |
397 | | - | |
398 | 403 | | |
399 | 404 | | |
400 | 405 | | |
401 | | - | |
| 406 | + | |
402 | 407 | | |
403 | 408 | | |
404 | 409 | | |
| |||
417 | 422 | | |
418 | 423 | | |
419 | 424 | | |
420 | | - | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
421 | 552 | | |
422 | 553 | | |
423 | 554 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
23 | 29 | | |
24 | 30 | | |
25 | 31 | | |
| |||
198 | 204 | | |
199 | 205 | | |
200 | 206 | | |
| 207 | + | |
201 | 208 | | |
202 | 209 | | |
203 | 210 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
12 | 16 | | |
13 | 17 | | |
14 | 18 | | |
| |||
207 | 211 | | |
208 | 212 | | |
209 | 213 | | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
210 | 230 | | |
211 | 231 | | |
212 | 232 | | |
| |||
0 commit comments