Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Separate mentions at the beginning of a post #97

Open
forenta opened this issue May 2, 2023 · 5 comments
Open

[Feature]: Separate mentions at the beginning of a post #97

forenta opened this issue May 2, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@forenta
Copy link

forenta commented May 2, 2023

Is your proposal related to a problem?

The longer discussions run, the more likely the display of addressed users will be distracting. Then follows a 'No, I don't think so' on 6-7 handles. To me, the display of the mention here seems more disturbing than useful.

Describe the solution you'd like

I would find it ideal if the handles appear next to the date, so that they are on the one hand visible for traceability, but do not disturb the reading flow. Or a separate line below the date in the same small font size. Or, if there's no other way, they should be completely hidden, as in the case of Elk and the bird.

Describe alternatives you've considered

Discuss topics on lemmyBB via Elk 😉

Additional context

No response

@forenta forenta added the enhancement New feature or request label May 2, 2023
@forenta forenta changed the title [Feature]: Hide mentions at the beginning of a post [Feature]: Separate mentions at the beginning of a post May 2, 2023
@Nutomic
Copy link
Member

Nutomic commented May 2, 2023

I assume you mean these @user in the beginning of posts which are sent by Mastodon and similar platforms. This is not only a problem in lemmybb but also in lemmy-ui so Im moving the issue.

Screenshot_20230502_215351

Screenshot_20230502_215421

Solving this is difficult, because these mentions are part of the HTML as sent by Mastodon. So removing them would require rewriting the HTML, which is complicated and error-prone. Replies from Lemmy dont have this problem because Lemmy doesnt include parent mentions in the comment HTML, but writes them to the metadata automatically.

@Nutomic Nutomic transferred this issue from LemmyNet/lemmyBB May 2, 2023
@dessalines
Copy link
Member

There could be a lot of unforseen problems in actually rewriting and saving an altered version html sent from mastodon and twitter-type ones.

But it could be solved in the front ends, by grouping mentions, and putting them behind a <details><summary IE a hidden spoiler type tag. Or any other number of ways to represent them.

@Nutomic
Copy link
Member

Nutomic commented May 25, 2023

Same issue in lemmy-ui repo: LemmyNet/lemmy-ui#1019

I think its better to implement it there, so that Lemmy backend doesnt have to do any HTML parsing and editing. Doing that in lemmy-ui should be easier.

@dessalines dessalines closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2023
@Nutomic
Copy link
Member

Nutomic commented May 25, 2023

Actually this issue was originally opened for lemmybb, so solving it in lemmy-ui doesn't help.

@Nutomic Nutomic reopened this May 25, 2023
@dessalines
Copy link
Member

This is something that the front-ends should handle IMO, because its an issue of representation of data. Different front ends might collapse these mentions in different ways, or not at all.

@Nutomic Nutomic transferred this issue from LemmyNet/lemmy May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants