-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gatsby-theme-minimal-blog]: Navigation Item active
color doesn't work.
#415
Labels
type: upstream
Outside of our control
Comments
LekoArts
added
type: upstream
Outside of our control
and removed
type: bug
An issue or pull request relating to a bug
labels
Jun 8, 2020
Thanks for the issue! This is an upstream issue and I filed a ticket: system-ui/theme-ui#990 |
Just went over it. Amazing repro description and kudos again. Feel free to keep this open for visibility or close it to your convenience. |
I've included a fix to this in the new major version |
This was referenced Jun 21, 2021
This was referenced Oct 18, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Hi there! First of all, thank you so much for your work. Your themes are amazing and as a rookie web developer, having sections properly modularized really helps.
I'm inheriting my site from your theme
gatsby-theme-minimal-blog
. I shadowed your navigation components so I could make a few changes on the Active links in the menu (I wanted to distinguish the active link from the rest), but after trying a few things they just don't work.Link to the component
I saw you added:
but I think the color is overridden by the
theme-ui
color, so it doesn't seem to take effect.I'm pretty new to GatsbyJS, React, Theme-UI and most of the other frameworks used, so I'm not sure this is right, but I've tried to override the nav item's styles in different ways and there was no way I could get that done.
Steps
If we remove
and
from the Navigation component, we don't get behavioral changes in the site, which I think might prove that active color not being applied.
The text was updated successfully, but these errors were encountered: