Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gatsby-theme-minimal-blog]: Navigation Item active color doesn't work. #415

Closed
cesards opened this issue Jun 7, 2020 · 3 comments · Fixed by #599 or #604
Closed

[gatsby-theme-minimal-blog]: Navigation Item active color doesn't work. #415

cesards opened this issue Jun 7, 2020 · 3 comments · Fixed by #599 or #604
Labels
type: upstream Outside of our control

Comments

@cesards
Copy link

cesards commented Jun 7, 2020

Description

Hi there! First of all, thank you so much for your work. Your themes are amazing and as a rookie web developer, having sections properly modularized really helps.

I'm inheriting my site from your theme gatsby-theme-minimal-blog. I shadowed your navigation components so I could make a few changes on the Active links in the menu (I wanted to distinguish the active link from the rest), but after trying a few things they just don't work.

Link to the component

I saw you added:

 ".active": { color: `heading` },

but I think the color is overridden by the theme-ui color, so it doesn't seem to take effect.

I'm pretty new to GatsbyJS, React, Theme-UI and most of the other frameworks used, so I'm not sure this is right, but I've tried to override the nav item's styles in different ways and there was no way I could get that done.

Steps

If we remove

".active": { color: `heading` },

and

activeClassName="active"

from the Navigation component, we don't get behavioral changes in the site, which I think might prove that active color not being applied.

@cesards cesards added the type: bug An issue or pull request relating to a bug label Jun 7, 2020
@LekoArts LekoArts added type: upstream Outside of our control and removed type: bug An issue or pull request relating to a bug labels Jun 8, 2020
@LekoArts
Copy link
Owner

LekoArts commented Jun 8, 2020

Thanks for the issue! This is an upstream issue and I filed a ticket: system-ui/theme-ui#990

@cesards
Copy link
Author

cesards commented Jun 8, 2020

Just went over it. Amazing repro description and kudos again. Feel free to keep this open for visibility or close it to your convenience.

@LekoArts
Copy link
Owner

LekoArts commented Jun 7, 2021

I've included a fix to this in the new major version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment