Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python library changelog is out-of-date, and please push git tags for releases #295

Open
SomberNight opened this issue Oct 10, 2024 · 3 comments

Comments

@SomberNight
Copy link

Re the release process of ledger-bitcoin:

  • PyPI has newer releases uploaded than what is listed in the changelog. It would be nice to keep the changelog up to date.
  • Could you please push git tags corresponding to the PyPI releases? (ideally even retroactively for at least the current latest release)
    If they exist, I could not find them.
@bigspider
Copy link
Collaborator

Thanks for opening this, indeed I forgot to update the changelog. Will update soon.

Not sure about git tags, as the tags are used for the embedded app's version, and there are client libraries in python, JS and Rust, I feel like it would just add to the confusion.

@SomberNight
Copy link
Author

SomberNight commented Oct 11, 2024

I forgot to update the changelog. Will update soon.

Thanks!

Not sure about git tags, as the tags are used for the embedded app's version, and there are client libraries in python, JS and Rust,

For reference, Trezor also has a huge repo that contains lots of loosely related projects, and they have an (IMO) decent git tag naming system for it: https://github.com/trezor/trezor-firmware/tags
e.g. they have python library related versions prefixed with python/

@bigspider
Copy link
Collaborator

Changelog updated; I'll think about the tags - maybe a scheme like client/python/2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants