Skip to content

🐛 Bug: [02-clown-availability] <Missing type> #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 tasks done
Dorfieeee opened this issue Oct 4, 2023 · 1 comment
Open
4 tasks done

🐛 Bug: [02-clown-availability] <Missing type> #278

Dorfieeee opened this issue Oct 4, 2023 · 1 comment
Labels
accepting prs Yes please, send a pull request! ♥ good first issue Good for newcomers type: bug Something isn't working

Comments

@Dorfieeee
Copy link

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.
  • This is the appropriate issue form for the bug I would like to report.

Expected

I expected the L11 to be let lastClown: string;.

https://github.com/LearningTypeScript/projects/blob/4bf708c250f1ff32f2ba2a6f4a6e38d3ca8e6298/projects/the-type-system/system-of-a-clown/02-clown-availability/solution.ts#L11C15-L11C15

Actual

let lastClown; => type any
anything can be assign to it which would eventually blow when .toUpperCase() is called.

Impacted Project

02-clown-availability
.../projects/the-type-system/system-of-a-clown/02-clown-availability

Additional Info

No response

@Dorfieeee Dorfieeee added the type: bug Something isn't working label Oct 4, 2023
@JoshuaKGoldberg
Copy link
Contributor

Heh, I think I'd left this out because evolving anys aren't necessarily issues. But if you want to add a : string I think that it makes sense. Thanks for the report!

@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Yes please, send a pull request! ♥ good first issue Good for newcomers labels Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs Yes please, send a pull request! ♥ good first issue Good for newcomers type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants