Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Parent Typing #3189

Open
JPMeehan opened this issue Feb 20, 2025 · 0 comments
Open

Improve Parent Typing #3189

JPMeehan opened this issue Feb 20, 2025 · 0 comments
Labels
documents This issue is related to documents

Comments

@JPMeehan
Copy link
Collaborator

JPMeehan commented Feb 20, 2025 •
edited
Loading

Any embed-only documents, e.g. ActiveEffect, cannot have a null parent while Stored.

Considerations

  • We can simply define ActiveEffect.Parent to have the correct types
  • This doesn't always help the generic functions that return a stored document
  • Many of those generic functions have been improved in the DocumentsV2 branch so they're specifically overridden in a way that's more likely to grab the correct variant of Stored.

Secondary considerations

  • Are there feasible ways using EmbeddedDataField to create documents with nonstandard parents?
@JPMeehan JPMeehan added the documents This issue is related to documents label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documents This issue is related to documents
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JPMeehan