Not 100% compliant

[CsSzili]

Came here to see real examples, got a simplified answer.
The video was good for explaining the basics, but I expected the code to follow all rules.
I wanted to see what it looks like, but I can only imagine it based on the rules and the style guides.

For example: 4.9.4 Functions - AV Rule 58 (page 26):
When declaring and defining functions with more than two parameters, the leading
parenthesis and the first argument will be written on the same line as the function name.
Each additional argument will be written on a separate line (with the closing parenthesis
directly after the last argument).

WindComponents calculate_wind(Float64 track, Float64 heading, 
                               Float64 wind_dir, Float64 wind_speed) {

Correct form (if written with better comments than "IDK"):

WindComponents calculate_wind( Float64 track,            // I don't know what is this due to lack of documentation and
                                                         // lack of my knowledge about planes.
                                                         // What's ground track?
                               Float64 heading,          // Where the plane is heading
                               Float64 wind_dir,         // The direction of the wind
                               uint16 rcv_max_instances) // The maximum number of instances of this
{
…
}

Couldn't find other public codes. Got more results for Java Server Facets (also JSF) than the AV one. :(
I guess this is a really unexplored topic.

[CsSzili]

Also, the jsf_types.h is useless. Rule 50 has an exception for this: std types may begin with a lowercase character.

[CsSzili]

AV Rule 61: Braces ({}) which enclose a block will have nothing else on the line except comments (if necessary).

[CsSzili]

The if-else jungle in density_altitude_calculator.cpp: main is crazy. You don't need that variable.
AV Rule 113: Single exit point.
Exception: A single exit is not required if such a structure would obscure or otherwise
significantly complicate (such as the introduction of additional variables) a function’s control
logic.

[chesslogical]

CsSzili I do not agree with your rants against the great LaurieWired. Laurie is the top dog, everyone knows it... as such there is always a tiny little dog nipping at her heels. Also it seems you are proud of yourself for all the inane rants, not sure if you are aware of how Github allows people to fork any repo. If you have a problem with Laurie's repo, fork it and prove you can make it way better, or go make silly rants on some other repo.

[CsSzili]

bet

[CsSzili]

Excuse me if I was rude, but I believe I was right.
I managed to reduce the excessive use of }}}} and I decreased the indentation from 6 to 2 in main@density_altitude_calculator.cpp. I removed the return variable, and now the code is much more readable and maintainable. The output of the original and my calculator is still the same after these modifications.

I also noticed another issue: the compliant and the non-compliant versions of the flight calculator program produce a different order of JSON keys. As a result, tests for the compliant and non-compliant versions can never produce the same output if we compare the output to the expected result or to the other version as a string.

[CsSzili]

Also, the code format is not consistent. The flight calculator has a numbered (1.) feature list instead of a dashed (-) one, and only the density calculator has a simulated error option.

[CsSzili]

Also, the density calculator doesn't check if the TAS is positive, but the turn calculator does. I don't know much about airplanes, but the code in turn calculator implies that TAS must be positive everywhere. It feels like a different person wrote each program.

[CsSzili]

THERE IS A CONSTANT VARIABLE CALLED two_point_zero IN FLIGHT CALCULATOR!
Explanation: "AV Rule 151: no magic numbers". But magic variables are allowed?
Did I change your mind about my "rants"?

[CsSzili]

new_reading = 150.0 + (i % 7) - 3.0
What happened with "no magic numbers"?

[CsSzili]

// 2. Envelope margins
struct EnvelopeMargins {...

Oh, sorry! I didn't know that these were the envelope margins!

[CsSzili]

AV Rule 152: Multiple variable declarations shall not be allowed on the same line.
I quote:

Float64 tas_kts, gs_kts, heading, track, ias_kts, mach, altitude_ft, agl_ft;
Float64 vs_fpm, weight_kg, bank_deg, vso_kts, vne_kts, mmo;

[CsSzili]

I could open atleast 10 different issues.

[CsSzili]

Done (atleast mostly)