[bot] Merge 24.11 to develop#984
Merged
github-actions[bot] merged 3 commits intodevelopfrom Nov 26, 2024
Merged
Conversation
* Set qcTraceName on ChromatogramGroupId. * Fix error importing Skyline documents with Spectrum Filters (#921) "Spectrum Filter" gets parsed from the Skyline document light:heavy ratios are not calculated for precursors that have a spectrum filter The spectrum filter is used when deciding which chromatogram to read from the .skyd file for a particular precursor. # Conflicts: # src/org/labkey/targetedms/parser/ChromatogramGroupId.java * Added constructor for ChromatogramGroupId that takes both qcTraceName and spectrumFilter. --------- Co-authored-by: nickshulman <nicksh@proteinms.net>
labkey-sweta
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Merging changes from: 651e69a
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
Verify all PRs before approving: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=fb_bot_merge_24.11