Skip to content

Commit 5ac31a5

Browse files
committed
A couple more CSP enhancements
1 parent 8c39563 commit 5ac31a5

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

server/embedded/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ project.publishing {
161161
artifact project.tasks.bootJar.outputs.files.singleFile
162162
pom {
163163
name = "LabKey Server Embedded"
164-
description = "LabKey classes for producing distributions with embedded TomCat."
164+
description = "Embedded Tomcat, Spring Boot, and the LabKey classes that configure these components"
165165
developers PomFileHelper.getLabKeyTeamDevelopers()
166166
licenses PomFileHelper.getApacheLicense()
167167
organization PomFileHelper.getLabKeyOrganization()

server/embedded/src/org/labkey/embedded/LabKeyServer.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public static void main(String[] args)
4545
return;
4646
}
4747

48-
// Issue 40038: Ride-or-die Mode - default to shutting down by default in embedded deployment scenario
48+
// Issue 40038: Ride-or-die Mode - default to shutting down by default
4949
if (System.getProperty(TERMINATE_ON_STARTUP_FAILURE) == null)
5050
{
5151
System.setProperty(TERMINATE_ON_STARTUP_FAILURE, "true");
@@ -70,7 +70,7 @@ public static void main(String[] args)
7070
String baseCsp = """
7171
default-src 'self' ;
7272
connect-src 'self' ${CONNECTION.SOURCES} ;
73-
object-src 'none' ;
73+
object-src ${OBJECT.SOURCES} ; /* Substitution value defaults to 'none' unless overridden by an admin */
7474
style-src 'self' 'unsafe-inline' ${STYLE.SOURCES} ;
7575
img-src 'self' data: ${IMAGE.SOURCES} ;
7676
font-src 'self' data: ${FONT.SOURCES} ;
@@ -862,5 +862,4 @@ public void setKeyStore(String keyStore)
862862
this.keyStore = keyStore;
863863
}
864864
}
865-
866865
}

server/embedded/src/org/labkey/embedded/LabKeyTomcatServletWebServerFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ private void addContextProperty(StandardContext context, String value, String na
275275
}
276276
}
277277

278-
// Issue 48565: allow for JSON-formatted access logs in embedded tomcat
278+
// Issue 48565: allow for JSON-formatted access logs
279279
private void configureJsonAccessLogging(Tomcat tomcat, LabKeyServer.JsonAccessLog logConfig)
280280
{
281281
var v = new JsonAccessLogValve();

0 commit comments

Comments
 (0)