Tweaks and Bug Fixes

Author: LT-Rascek

ChangeLog.txt

@@ -27,7 +27,7 @@ Decisions:
       - "Gothic Hero" modifier increases Legitimacy gain, grants 0.05 Monthly Renown, and 0.5 Monthly Prestige, and most Vassal Stance Opinion while reducing Minority Vassal Stance Opinion
 
 Culture:
-- "Stratocratic Elite" reduces culture acceptance required for hybridization by 10
+- "Stratocratic Elite" reduces culture acceptance required for hybridization by 20
 - Sarmatian culture changes:
    - Iazyges start with "Writing" and "Oral Law" Innovations
    - Consolidated Iazyges and Sarmatian name lists
@@ -66,6 +66,7 @@ Tweaks:
       - If adopting a government without treasury, gain 160 gold times your rank less one (so Dukes get 160 and Kings get 320)
       - If adopting a government with treasury, gain 40 gold times your rank less one and 120 treasury times your rank less one
       - In either case, this value is the maximum; you only gain enough of either to hit that limit
+- Diocletian's Palace is enabled for Greco-Roman cultures, Roman Political Cultures, or Roman Governments
 - Culture Hybridization requires a minimum of 10 acceptance to hybridize
 - Hegemonies and Empires can no longer use border raids (they are too large to bother with such minimalist wars)
 - If Augustulus wins the war with Odoacer, he imprisons all the Federates and all the Federate titles dissolve (instead of just Odoacer's)
@@ -75,6 +76,8 @@ Tweaks:
 - Clarified various kingdom and empire landing decisions so people aren't confused when their primary title is titular and they possess a non-titular title
 
 Bug Fixes:
+- Fixed some edge cases leading to Tribal rulers having noble family titles
+- Ended tributary status when successfully migrating
 - Fixed bug causing Slavic culture traditions to be removed early
 - Fall of Rome informational event fire failure fixed
 - Blocked an edge case where Coronations could spawn Holy Orders before the necessary innovation

WtWSMS/common/buildings/BP_special_buildings.txt

@@ -376,8 +376,9 @@ diocletian_palace = {
 
 	is_enabled = {
 		OR = {
-			scope:holder.culture = { has_cultural_pillar = heritage_latin }
-			scope:holder.culture = { has_cultural_pillar = heritage_byzantine }
+			scope:holder.culture = { has_cultural_parameter = greco_roman_social_tradition }
+			scope:holder.culture = { has_cultural_parameter = can_restore_roman_empire }
+			scope:holder = { government_has_flag = is_a_roman_government }
 		}
 	}
 

WtWSMS/common/on_action/BP_on_actions/BP_title_on_actions.txt

@@ -228,9 +228,34 @@ on_vassal_change = {
 	on_actions = {
 		BP_degrade_roman_government
 		BP_cleanup_landless_chars_under_non_admin
+		BP_completely_landless_realm_vassal_change
 	}
 }
 
+BP_completely_landless_realm_vassal_change = {
+	trigger = {
+		scope:old_liege ?= {
+			is_independent_ruler = yes
+			government_allows = administrative
+			is_landed = no
+			trigger_if = {
+				limit = { any_vassal = { count > 0 } }
+				any_vassal_or_below = { count < 1 is_landed = yes primary_title.tier >= tier_county }
+			}
+		}
+	}
+	effect = {
+		scope:old_liege ?= {
+			if = {
+				limit = { any_vassal = { count > 0 } }
+				every_vassal_or_below = { every_held_title = { prev = { destroy_title = prev } } }
+			}
+			every_held_title = { prev = { destroy_title = prev } }
+		}
+	}
+}
+
+
 BP_degrade_roman_government = {
 	effect = {
 		### If an admin ruler becomes independent, who are not of a high enough rank, changes government

WtWSMS/common/script_values/BP_culture_values.txt

@@ -59,4 +59,4 @@ number_of_counties_of_ruler_culture = { #Char Scope
 	every_county = { limit = { this.culture = prev.culture is_landless_type_title = no } add = 1 }
 }
 
-lower_hybridization_acceptance_value = 10
+lower_hybridization_acceptance_value = 20

WtWSMS/common/scripted_effects/07_dlc_ep3_scripted_effects_BP_overwrite.txt

@@ -724,6 +724,7 @@ ep3_become_landed_transfer_effect = {
 
 admin_government_reset_effect = {}
 
+##### Changed from Vanilla: Caught some weird edge effects relating to tribal landing
 ##### Changed from Vanilla: Catch some additional new admin governments!
 create_noble_family_effect = {
 	debug_log = create_noble_family_title
@@ -876,25 +877,43 @@ create_noble_family_effect = {
 				}
 			}
 		}
-		scope:new_title.holder ?= {
-			save_scope_as = noble_family_head
-			scope:new_title = { set_coa = scope:noble_family_head.house }
-		}
-		custom_description = { text = create_noble_family_tt }
-
-		#Notifications
-		every_player = {
+		##### Changed from Vanilla vvvvv
+		if = { #Only Tribal Holdings; remove that nf title
 			limit = {
-				top_liege = scope:new_noble_family_holder.top_liege
-				this != scope:new_noble_family_holder
-				# China has hundreds of Noble Families, it gets spammy
-				NOT = { government_allows = merit }
+				scope:new_noble_family_holder = {
+					any_held_title = {
+						count = all
+						OR = {
+							this.title_province = { has_holding_type = tribal_holding }
+							is_noble_family_title = yes
+						}
+					}
+				}
 			}
-			trigger_event = {
-				id = ep3_emperor_yearly.2410
-				days = 1
+			scope:new_noble_family_holder = { destroy_title = scope:new_title }
+		}
+		else = {
+			scope:new_title.holder ?= {
+				save_scope_as = noble_family_head
+				scope:new_title = { set_coa = scope:noble_family_head.house }
+			}
+			custom_description = { text = create_noble_family_tt }
+
+			#Notifications
+			every_player = {
+				limit = {
+					top_liege = scope:new_noble_family_holder.top_liege
+					this != scope:new_noble_family_holder
+					# China has hundreds of Noble Families, it gets spammy
+					NOT = { government_allows = merit }
+				}
+				trigger_event = {
+					id = ep3_emperor_yearly.2410
+					days = 1
+				}
 			}
 		}
+		##### Changed from Vanilla ^^^^^
 	}
 
 	debug_log_scopes = yes

WtWSMS/common/scripted_effects/BP_migration_situation_war_effects.txt

@@ -10,6 +10,11 @@ migration_cb_title_and_modifier_application_effect = {
 		}
 	}
 
+	if = {
+		limit = { scope:attacker = { is_tributary = yes } }
+		scope:attacker = { end_tributary = yes }
+	}
+	
 	create_title_and_vassal_change = {
 		type = independency
 		save_scope_as = change_attacker_titles_vassals_independent

WtWSMS/common/scripted_effects/BP_roman_administrative_effects.txt

@@ -279,11 +279,10 @@ change_government_subroman_administrative_effect = {
 			else = { this.domicile = { move_domicile = prev.top_liege.capital_county.title_province } }
 		}
 		hidden_effect = {
-			add_treasury = {
+			add_treasury = { #Give starting treasury
 				value = 100
 				multiply = {
 					value = primary_title.tier
-					subtract = 2
 					min = 1
 				}
 			}
@@ -304,7 +303,6 @@ change_government_roman_administrative_effect = {
 				value = 100
 				multiply = {
 					value = primary_title.tier
-					subtract = 2
 					min = 1
 				}
 			}

_developer_documentation/_BP_scratchpad.info

@@ -12,11 +12,27 @@ Current Tasks:
 	- Make Faith conversion continue until complete
 	- Slavic Traditions getting abandoned because of the stupid era trigger
 	- Augustulus is not getting fully unlanded
+	- On change government catch for noble families in non-admin realms
 
+- Customary drift isn't getting blocked correctly... first valid use instead?
+- Conversion did not trigger concubines keeping event
+- Flipping to sub-roman isn't triggering noble families for vassals...
+- No court languages for MM/MO
+
+- Diocletian's palace needs different enable triggers
+- Sic Transit Gloria Mundi for generic fall of rome text
+- Migration Phase:
+   - More troops for migrators
+   - Fix AI logic relating to migration wars; lombard went for 3 counties
+      - ai_score probably
+      - Possibly needs is_shown trigger just for AI instead
 - Alamanii should start divided because they expand too much
 - Break Tributary status after migration?
+- Rivalry between Syagrius and his neighbors
+- AIs aren't fleeing large confederations
 
 - Despoliation Track 4 (Barbarian Settlement) should make de jure establishment cheaper
+- hostile_raid_time reduction for Roman Empire, Successor States, and Barbarian Kingdoms
 - Minority decline mechanic
 
 - Thrace able to vassalize the Steppe...