Fix Romulus still being landed at the end of the war

Author: LT-Rascek

ChangeLog.txt

@@ -82,6 +82,7 @@ Tweaks:
 - Clarified various kingdom and empire landing decisions so people aren't confused when their primary title is titular and they possess a non-titular title
 
 Bug Fixes:
+- Fixed bug leading to Romulus being still landed when loosing the war with Odoacer
 - Reduced tendency of AI to engage in stupid migrations
 - Tweaked language/heritage drift to not fire quite as often
 - Fixed an edge case leading to a lack of NF titles in newly minted Sub-Roman Admin realms

WtWSMS/common/casus_belli_types/BP_event_war.txt

@@ -217,15 +217,52 @@ odoacer_takeover_war = { #Cribbed from invasion wars
 			trigger_event = { on_action = BP_create_federate_commander }
 		}
 
-		
-		
 		#Step 5: Clean up extraneous claims of unlanded defenders
 		if = {
 			limit = { scope:defender = { is_landed = no } }
 			scope:defender = { every_claim = { prev = { remove_claim = prev } } }
 		}
 
-		#Step 6: Handle the offices if playing with the DLC
+		#Step 6: If the defender is _still_ landed, that goes to either the duchy holder or Odoacer
+		if = {
+			limit = { scope:defender = { is_landed = yes } }
+			create_title_and_vassal_change = {
+				type = granted
+				save_scope_as = extra_county_delanding
+				add_claim_on_loss = no
+			}
+			scope:defender = {
+				every_held_title = {
+					limit = {
+						is_noble_family_title = no
+						tier = tier_county
+					}
+					add_to_list = counties_to_take_again
+				}
+			}
+			every_in_list = {
+				list = counties_to_take_again
+				if = {
+					limit = {
+						exists = this.duchy.holder
+						NOT = { this.duchy.holder = scope:defender }
+					}
+					change_title_holder = {
+						holder = this.duchy.holder
+						change = scope:extra_county_delanding
+					}
+				}
+				else = {
+					change_title_holder = {
+						holder = scope:attacker
+						change = scope:extra_county_delanding
+					}
+				}
+			}
+			resolve_title_and_vassal_change = scope:extra_county_delanding
+		}
+		
+		#Step 7: Handle the offices if playing with the DLC
 		if = {
 			limit = { BP_has_dlc_necessary_for_roman_admin_governments_trigger = yes }
 			#Setup Italian Magister Officiorum

_developer_documentation/_BP_medium_term_goals_ideas.info

@@ -51,6 +51,9 @@ General TODOs:
 ----------
 
 Mechanics:
+- Minority System Overhaul:
+   - Minority decline mechanic
+   - Complete code cleanup
 - Offer federates during migration wars to end the war and give them a duchy
    - Models how the Vandals/Alans/Suebi were handled during the early Vth century
    - Blocks Migration Wars for a decade or so (if given kingdom)
@@ -59,9 +62,11 @@ Mechanics:
    - Should be a great project like the Chinese have
 - Frankish inter-confederation wars?
    - If so, unlocks some of the mechanics for Frankish succession.
-- Laws for controlling the baseline power of the Diarchies in Persia/Rome?
-- Corruption Laws for Admin Realms
-- More detail for Roman/Persian taxation
+Laws:
+   - Laws for controlling the baseline power of the Diarchies in Persia/Rome?
+   - Corruption Laws for Admin Realms
+   - Currency debasement laws for Admin Realms
+   - More detail for Roman/Persian taxation
 
 Bookmarks:
 - Frankish conquest of Trier?
@@ -77,6 +82,9 @@ Bookmarks:
    - 481 Bookmark as well?
 
 CBs:
+- Odoacer Event War (*sigh*):
+   - Augustulus is still landed before "Step 7: Handle the offices if playing with the DLC"
+   - This is almost certainly fixable, but requires reworking the entire victory chain
 - Migration CB Rework (Part Deuce):
    - Multiple migrators logic:
       - Events to bring vassals into the fight need overhaul

_developer_documentation/_BP_scratchpad.info

@@ -10,9 +10,6 @@ Validator Update:
 Current Tasks:
 ----------
 	- Make Faith conversion continue until complete
-	- Augustulus is not getting fully unlanded
-
-- Minority decline mechanic
 
 Edge Cases:
 - Thrace able to vassalize the Steppe...