Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOM Behaviour #29

Open
cdebom opened this issue Aug 7, 2020 · 5 comments
Open

FOM Behaviour #29

cdebom opened this issue Aug 7, 2020 · 5 comments

Comments

@cdebom
Copy link

cdebom commented Aug 7, 2020

Dear @joezuntz and @EiffL. We found out that the resulting FOM_3x2 can be very different in multiple trainings.

For instance, if we use the RF example w/ 5% for training (100 times - 5 bins) we have found in the validation

image

Thus, one can find 10^4 as well as 6*10^4 using the same algorithm.

while the SNR_3x2 have variations lowers than 0.6 :

`image

If, instead of using RF we add the same the redshifts in the correct bin for the validation sample we find (5 bins) FOM_3x2 lower than 3x10^4, depending upon some selection. Thus we are getting Higher values than using the truth table.

Does this make sense for you?

@pwhatfield
Copy link

tomo_4
I have found a similar issue when varying parameters that describe the training smoothly, see figure, the FOM values jump around a fair bit...

@dkirkby
Copy link
Member

dkirkby commented Aug 27, 2020

Are you using jax-cosmo option to calculate the FoM? It should have better numerical stability.

@pwhatfield
Copy link

Er probably not sorry; does tc.compute_scores just need jax-cosmo=True or something?

@EiffL
Copy link
Member

EiffL commented Aug 31, 2020

yes, essentially :-)
@cdebom were you using the jax-cosmo version of the metrics? Because they should be more stable

@cdebom
Copy link
Author

cdebom commented Sep 1, 2020

Yes, it seems that this was the issue. We are using jax-cosmo now. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants