Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable this dialog when importing. #7145

Open
Gabrielxd195 opened this issue Mar 13, 2024 · 5 comments · May be fixed by #7613
Open

Disable this dialog when importing. #7145

Gabrielxd195 opened this issue Mar 13, 2024 · 5 comments · May be fixed by #7613
Labels
Milestone

Comments

@Gabrielxd195
Copy link

Bug Summary

When you import a long sample or a heavy plugin, a small dialog box appears that freezes while the sample or plugin is opened, but if lmms freezes the dialog box stays on top of the other programs. This happens a lot on low-resource PCs.

Expected behavior

No dialog box appears when importing.

Screenshot

Cuadro de dialogo de muestras

Cuadro de dialogo de muestras 2

Affected LMMS versions

Versión 1.3.0-alpha.1.532+gc991a85ee (Linux/x86_64, Qt 5.9.5, GCC 7.5.0).

Click to expand

@0hStormy
Copy link

0hStormy commented Mar 13, 2024

Have the same issue on Windows, so if you need confirmation that this isn't just a Linux problem

@Gabrielxd195
Copy link
Author

Have the same issue on Windows, so if you need confirmation that this isn't just a Linux problem

I am testing it on Linux, but this feature is specific to lmms and is in all operating systems.

@Rossmaxx
Copy link
Contributor

That dialog is bugged. I've noticed it too, don't remember exactly what lines of code to look at. Might be good candidate for 1.3.

@Rossmaxx Rossmaxx added this to the 1.3 milestone Nov 30, 2024
@Rossmaxx
Copy link
Contributor

I'm inviting @regulus79 because they are looking at fixing Ui bugs rn and is active here.

@regulus79 regulus79 linked a pull request Dec 1, 2024 that will close this issue
@regulus79
Copy link
Contributor

regulus79 commented Dec 1, 2024

hi :)

That dialog you are referring to is a TextFloat, defined in TextFloat.h, which is a widget that spawns when loading a sample/vst/whatever. Notably, it uses the QWindowFlags of Qt::ToolTip in its constructor. This causes it to remain on top of all windows, even windows not part of the application.

I was unsuccessful in trying to disable the Qt::WindowStaysOnTopHint, but I found online another person who was experiencing difficulties with the ToolTip window flag, and someone recommended that they use the Qt::Tool window flag combined with the Qt::FramlessWindowHint flag https://forum.qt.io/post/104793.

I tested everything by commenting out the line delete tf which removed the dialog after the loading. This allowed the dialog to stay up as long as I needed it to test its properties. I found that this solution did indeed solve the issue. However, in normal operation, my computer is fast enough that the tooltip does not appear. I would love if people could test #7613, particularly with large files or slower computers.

@Rossmaxx Rossmaxx linked a pull request Dec 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants