Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok y'all, I've finally gone through all the code and PEP8-ified the spack core and the packages. This is important so that the checks we do on PRs are meaningful, and so that it's easy to contribute compliant code without having to fix others' issues.
I added a few exceptions:
json
schemas fromconfig.py
into their own modules, which should make the code easier to manage.See what you think before this goes in.
@adamjstewart @davydden @alalazo @robertdfrench @becker33