Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 compliance #1496

Merged
merged 5 commits into from
Aug 11, 2016
Merged

PEP8 compliance #1496

merged 5 commits into from
Aug 11, 2016

Conversation

tgamblin
Copy link
Member

@tgamblin tgamblin commented Aug 10, 2016

Ok y'all, I've finally gone through all the code and PEP8-ified the spack core and the packages. This is important so that the checks we do on PRs are meaningful, and so that it's easy to contribute compliant code without having to fix others' issues.

I added a few exceptions:

  • Visual indents (which seem hard to fix and don't add much to the code in the situations I've encountered)
  • The checker script makes exceptions for URLs and file paths exceptions a bit more aggressively now.
  • Factor out the various json schemas from config.py into their own modules, which should make the code easier to manage.

See what you think before this goes in.
@adamjstewart @davydden @alalazo @robertdfrench @becker33

@tgamblin tgamblin changed the title Features/pep8 compliance PEP8 compliance Aug 10, 2016
@becker33 becker33 merged commit f59653a into develop Aug 11, 2016
@robertdfrench
Copy link
Contributor

A+++ would merge again.

@tgamblin tgamblin deleted the features/pep8-compliance branch October 11, 2016 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants