Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save clang-format git patch as artifact on failure #1208

Closed
samuelpmishLLNL opened this issue Aug 12, 2024 · 2 comments · Fixed by #1210
Closed

save clang-format git patch as artifact on failure #1208

samuelpmishLLNL opened this issue Aug 12, 2024 · 2 comments · Fixed by #1210
Labels
CI Continuous Integration enhancement New feature or request

Comments

@samuelpmishLLNL
Copy link
Contributor

Right now, if the CI job for checking style fails, it dumps text to the log that can be made into a patch. However, that text is interleaved with some other console output, and seemingly prefixed by timestamps, which means it takes manual effort to produce the actual patch file that can be git apply-ed. On my machine/browser, the Azure devops UI doesn't play nicely with text selections (e.g. vertically scrolling the log changes the selected text) which makes it annoying to successfully select the relevant patch info.

It would be more ergonomic if instead, on a style failure the patch information would be written to a file that gets uploaded as an artifact. That way, the user only has to click a button to download the file and we're sure that no clerical errors were made when manually creating the patch.

@samuelpmishLLNL samuelpmishLLNL added enhancement New feature or request CI Continuous Integration labels Aug 12, 2024
@white238
Copy link
Member

white238 commented Aug 12, 2024

You can comment on the PR "/style" now and it will style your code and apply it to your branch.

@samuelpmish
Copy link
Contributor

oh, I wasn't aware of that change. Is it documented somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants