Tupek/additional profiling #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
white238
reviewed
Aug 6, 2024
| { | ||
| } | ||
| #endif | ||
|
|
||
| /// finds tau s.t. (z + tau*d)^2 = trSize^2 | ||
| void project_to_boundary_with_coefs(mfem::Vector& z, const mfem::Vector& d, double trSize, double zz, double zd, | ||
| void projectToBoundaryWithCoefs(mfem::Vector& z, const mfem::Vector& d, double trSize, double zz, double zd, |
There was a problem hiding this comment.
Thanks for the correction in capitalization!
white238
reviewed
Aug 6, 2024
white238
reviewed
Aug 6, 2024
tupek2
force-pushed
the
tupek/additional_profiling
branch
from
563e87f to
765219e
Compare
white238
reviewed
Aug 9, 2024
tupek2
added
ready for review
btalamini
approved these changes
Aug 19, 2024
| /// max cumulative iterations | ||
| size_t maxCumulativeIteration = 1; | ||
| size_t max_cumulative_iteration = 1; |
There was a problem hiding this comment.
Is this setting the number of cumulative CG iterations before the precondtioner is updated? If so, I suggest the name be more descriptive, even if it ends up long.
chapman39
reviewed
Aug 19, 2024
|
/style |
white238
reviewed
Aug 20, 2024
white238
reviewed
Aug 20, 2024
white238
reviewed
Aug 20, 2024
white238
reviewed
Aug 20, 2024
white238
reviewed
Aug 20, 2024
|
/style |
chapman39
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add caliper instrumentation, change some names to match convention, work on expanding nonlinear test.