Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchpark version clones spack #592

Closed
pearce8 opened this issue Feb 5, 2025 · 1 comment
Closed

Benchpark version clones spack #592

pearce8 opened this issue Feb 5, 2025 · 1 comment
Assignees
Labels
docs Improvements or additions to documentation

Comments

@pearce8
Copy link
Collaborator

pearce8 commented Feb 5, 2025

Describe the bug
benchpark version clones spack

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://software.llnl.gov/benchpark/getting-started.html'
  2. Follow the directions we give users
  3. Notice the spack cloning when you type benchpark version

Expected behavior
Are we subsequently using the cloned spack? If not, should we be having instructions here - or move the version check to after a workspace is created?

Supercomputer (please complete the following information):

  • system: any
@pearce8 pearce8 added the docs Improvements or additions to documentation label Feb 5, 2025
@michaelmckinsey1
Copy link
Collaborator

michaelmckinsey1 commented Feb 6, 2025

In main.py, import benchpark.cmd.audit calls bootstrapper.bootstrap(), which is what installs ramble and spack if they do not already exist in the path (i.e. will happen for fresh install).

One way I can think of to address this is to check before the import and exit if using benchpark -V or benchpark --version, like here #595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants