Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes build and tests on Windows #1519

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

kennyweiss
Copy link
Member

Summary

  • This PR is a bugfix for the build on Windows
  • It fixes:
    • the MIR build, which required some exports for static members
    • MIR tests that depend on the compile time path to the data directory
    • A bug with the quicksort algorithm for some data orderings and adds a unit test
    • Some quest tests when mfem does not have MPI
    • Some quest lambdas that take a constexpr -- MSVC appears to require static constexpr w/ c++14. This might be relaxed in c++17
  • I also cleaned up/updated some sidre::Group implementations to use the iterator interface while working on sidre test bugfixes

Status:

@kennyweiss kennyweiss added bug Something isn't working Build system Issues related to Axom's build system maintenance Issues related to code maintenance Windows Related to Windows development labels Mar 12, 2025
@kennyweiss kennyweiss self-assigned this Mar 12, 2025
@kennyweiss kennyweiss added this to the April 2025 Release milestone Mar 12, 2025
@kennyweiss
Copy link
Member Author

/style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Build system Issues related to Axom's build system maintenance Issues related to code maintenance Windows Related to Windows development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant