Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate if we can remove the AXOM_ENABLE_MFEM_SIDRE_DATACOLLECTION config variable #1497

Open
kennyweiss opened this issue Jan 29, 2025 · 0 comments
Open

Investigate if we can remove the AXOM_ENABLE_MFEM_SIDRE_DATACOLLECTION config variable #1497

kennyweiss opened this issue Jan 29, 2025 · 0 comments
Labels
Build system Issues related to Axom's build system maintenance Issues related to code maintenance Sidre Issues related to Axom's 'sidre' component

Comments

@kennyweiss
Copy link
Member

We added the AXOM_ENABLE_MFEM_SIDRE_DATACOLLECTION configuration variable during a transition point where some users were using the SidreDataCollection in mfem and others were using the one in Axom.

I think at this point we always have MFEMSidreDataCollection when we have mfem and sidre.
If so, we should remove the AXOM_ENABLE_MFEM_SIDRE_DATACOLLECTION config variable.
@kennyweiss kennyweiss added Build system Issues related to Axom's build system maintenance Issues related to code maintenance Sidre Issues related to Axom's 'sidre' component labels Jan 29, 2025
@kennyweiss kennyweiss mentioned this issue Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build system Issues related to Axom's build system maintenance Issues related to code maintenance Sidre Issues related to Axom's 'sidre' component
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kennyweiss