-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a memory leak in axom::Array copy constructor #1482
Conversation
|
||
TEST(core_array, regression_array_move) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kennyweiss -- I replaced the regression test you added in #1286 with a unit test that I think should capture all the leaky cases you were seeing. Let me know if you'd rather keep the regression test as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @publixsubfan -- it looks like it covers similar/more ground, so I'm ok w/ removing the old regression case.
Did you check the bugfix against lsan and/or valgrind or a similar tool?
34fbe64
to
a6f5335
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @publixsubfan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @publixsubfan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @publixsubfan -- please update the RELEASE-NOTES to reflect the bugfix
|
||
TEST(core_array, regression_array_move) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @publixsubfan -- it looks like it covers similar/more ground, so I'm ok w/ removing the old regression case.
Did you check the bugfix against lsan and/or valgrind or a similar tool?
@kennyweiss - yep, I tested with an lsan build with and without the bugfix commit. |
a5c9634
to
c9101fe
Compare
Summary
axom::Array
copy constructor, along the lines of the fix in commit ae8e8c7