Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade upload-artifact action to v4 #1426

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

@kennyweiss kennyweiss added CI Issues related to continuous integration maintenance Issues related to code maintenance Windows Related to Windows development labels Sep 25, 2024
@kennyweiss
Copy link
Member Author

kennyweiss commented Sep 26, 2024

The changes to the upload action were sufficient to pass the manual Windows build CI -- https://github.com/LLNL/axom/actions/runs/11043175315

However, some of the other actions are also deprecated (actions/checkout@v2, actions/setup-python@v2), and should also be fixed.

Update: Fixed

Updates `actions/checkout` and `actions/setup-python` in manual Windows TPL CI
@kennyweiss kennyweiss merged commit 0d3b3be into develop Sep 26, 2024
13 checks passed
@kennyweiss kennyweiss deleted the feature/kweiss/fix-gh-action-manual-windows branch September 26, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues related to continuous integration maintenance Issues related to code maintenance Windows Related to Windows development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants