Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check removeFile() return value #1415

Closed
2 tasks done
bmhan12 opened this issue Sep 18, 2024 · 2 comments
Closed
2 tasks done

Check removeFile() return value #1415

bmhan12 opened this issue Sep 18, 2024 · 2 comments
Labels
Core Issues related to Axom's 'core' component maintenance Issues related to code maintenance Reviewed

Comments

@bmhan12
Copy link
Contributor

bmhan12 commented Sep 18, 2024 •
edited
Loading

Issue is opened from this discussion.

  • Various parts of the code call removeFile, but do not verify that the file has actually been deleted through the return code/checking if file stills exist. Warning, error, or at least some indication should be given to user if file deletion has failed.
  • Fix removeFile usage on Windows in slic_macros.cpp test case (from original discussion)
@bmhan12 bmhan12 added Core Issues related to Axom's 'core' component maintenance Issues related to code maintenance labels Sep 18, 2024
This was referenced Sep 18, 2024
Merged
Merged
@kennyweiss
Copy link
Member

Related: @agcapps noted in #1421 that Unlink on Windows only works when all file handles are closed.

@bmhan12
Copy link
Contributor Author

bmhan12 commented Sep 30, 2024

Closed by #1424

@bmhan12 bmhan12 closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core Issues related to Axom's 'core' component maintenance Issues related to code maintenance Reviewed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kennyweiss @rhornung67 @bmhan12