Allow device policy execution for IntersectionShaper, DistributedClosestPoint #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmhan12
force-pushed
the
feature/han12/unified_outstanding
branch
from
4fe8f0f to
0d90639
Compare
bmhan12
requested review from
BradWhitlock,
kennyweiss,
rhornung67,
publixsubfan and
gunney1
kennyweiss
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Thanks for following up on this @bmhan12 !
Did you notice any performance improvements in this branch w.r.t the unified memory usage in develop?
Comment on lines
+1065
to
+1068
| axom::Array<double> sqDistThresh_host( | ||
| 1, | ||
| 1, | ||
| axom::execution_space<axom::SEQ_EXEC>::allocatorID()); |
|
|
||
| // Determine new allocator (for CUDA/HIP policy, set to Unified) | ||
| // Set new default to device | ||
| axom::setDefaultAllocator(::getUmpireDeviceId<ExecSpace>()); |
There was a problem hiding this comment.
👍
+1 for reducing our usage of the global default allocator!
white238
reviewed
Aug 8, 2024
| @@ -705,19 +693,20 @@ class IntersectionShaper : public Shaper | |||
| this->getDC()->RegisterField(volFracName, volFrac); | |||
|
|
|||
| // Initialize hexahedral elements | |||
| m_hexes = axom::Array<HexahedronType>(NE, NE); | |||
| axom::ArrayView<HexahedronType> hexes_view = m_hexes.view(); | |||
| m_hexes = axom::Array<HexahedronType>(NE, NE, kernel_allocator); | |||
There was a problem hiding this comment.
Should we be toggling between kernel and device in our naming?
There was a problem hiding this comment.
Good catch! Changed kernel_allocator to device_allocator to keep naming standard.
…round for getCandidates(point)
…es workaround for getCandidates(point)" - implementation fails when ats is disabled for cuda, BitSet::size() seemingly cannot be found on either host or device" This reverts commit a081b7e.
bmhan12
force-pushed
the
feature/han12/unified_outstanding
branch
from
2c8f83f to
0dc759c
Compare
I didn't do any major benchmarking, but at least for the
|
rhornung67
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: