Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external fmt dependency #1302

Open
kennyweiss opened this issue Mar 25, 2024 · 0 comments
Open

Support external fmt dependency #1302

kennyweiss opened this issue Mar 25, 2024 · 0 comments
Labels
App Integration Issues related to integration with applications Build system Issues related to Axom's build system CI Issues related to continuous integration Reviewed TPL Issues related to Axom's third party libraries

Comments

@kennyweiss
Copy link
Member

Axom currently vendors a copy of the fmt library in the <axom>/src/thirdparty/axom/fmt directory and places it under the axom::fmt namespace to avoid clashes with other common libraries that use fmt, e.g. conduit and umpire. This is convenient since fmt is a required dependency for axom and we cannot build the code without it.

In their latest release, umpire began using an external fmt, e.g. built/installed through spack or vcpkg, which has created some issues for axom developers and users in their various build and test configurations. Notably, in #1301, we had to disable Umpire in our Windows build due to ambiguities between the built-in and external fmt in the vcpkg configuration.

To resolve these, axom should support both an externally built/configured fmt, when supplied, and an internal/vendored/submoduled copy otherwise.

Once this is resolved, we can add umpire back to our vcpkg configuration.

@kennyweiss kennyweiss added App Integration Issues related to integration with applications TPL Issues related to Axom's third party libraries CI Issues related to continuous integration Build system Issues related to Axom's build system labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Integration Issues related to integration with applications Build system Issues related to Axom's build system CI Issues related to continuous integration Reviewed TPL Issues related to Axom's third party libraries
Projects
None yet
Development

No branches or pull requests

2 participants