Skip to content

Commit ba4da44

Browse files
committed
Fixed unit test and added build status.
1 parent fcf6e90 commit ba4da44

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

README.md

+2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
## AWS Lambda Go Api Proxy
22

3+
[![CircleCI](https://circleci.com/gh/LF-Engineering/aws-lambda-go-api-proxy/tree/master.svg?style=svg&circle-token=7a4af389ad43eb22517668fa8997847e3d981de4)](https://circleci.com/gh/LF-Engineering/aws-lambda-go-api-proxy/tree/master)
4+
35
**LF Notice**: this is a fork of [github.com/awslabs/aws-lambda-go-api-proxy](github.com/awslabs/aws-lambda-go-api-proxy) that contains:
46

57
* Fix for response headers (current master branch in upstream is broken)

core/response_test.go

+8-2
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,10 @@ var _ = Describe("ResponseWriter tests", func() {
154154
Expect(err).To(BeNil())
155155

156156
// Headers are not written to `Headers` field
157-
Expect(0).To(Equal(len(proxyResponse.Headers)))
157+
// TODO: DAD - why is this test here (commented out for now)? Added
158+
// back the logic to copy over headers - without this the
159+
// 'Content-Type' is NOT passed through properly
160+
//Expect(0).To(Equal(len(proxyResponse.Headers)))
158161
Expect(1).To(Equal(len(proxyResponse.MultiValueHeaders["Content-Type"])))
159162
Expect("application/json").To(Equal(proxyResponse.MultiValueHeaders["Content-Type"][0]))
160163
})
@@ -168,7 +171,10 @@ var _ = Describe("ResponseWriter tests", func() {
168171
Expect(err).To(BeNil())
169172

170173
// Headers are not written to `Headers` field
171-
Expect(0).To(Equal(len(proxyResponse.Headers)))
174+
// TODO: DAD - why is this test here (commented out for now)? Added
175+
// back the logic to copy over headers - without this the
176+
// 'Content-Type' is NOT passed through properly
177+
//Expect(0).To(Equal(len(proxyResponse.Headers)))
172178

173179
// There are two headers here because Content-Type is always written implicitly
174180
Expect(2).To(Equal(len(proxyResponse.MultiValueHeaders["Set-Cookie"])))

0 commit comments

Comments
 (0)