Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"final" standard service implementations #49

Open
PetrilloAtWork opened this issue Feb 23, 2024 · 0 comments
Open

"final" standard service implementations #49

PetrilloAtWork opened this issue Feb 23, 2024 · 0 comments

Comments

@PetrilloAtWork
Copy link
Contributor

ICARUS is forced to copy the whole DetectorPropertiesStandard class in order to have a small custom change.

I think that fundamental "standard" classes should be allowed to be inherited from and modified.

lardataalg/lardataalg/DetectorInfo/DetectorPropertiesStandard.h

Line 36 in b2751d6

class DetectorPropertiesStandard final : public DetectorProperties {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PetrilloAtWork