feat(search): Add Search Functionality to Resource List in Insights Page #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Makefile to use full path for swag and swagger commands - Add 'keyword' query parameter to OpenAPI specification files - Modify search handler to support keyword filtering in SQL queries - Enable keyword search in UI search input component
Cookiery
requested review from
elliotxx,
ruquanzhao,
hai-tian,
panshuai111,
adohe and
ffforest
as code owners
Cookiery
changed the title
|
Your movement is fast, let me take a look at these modifications. |
MDA1422
reviewed
Feb 9, 2025
MDA1422
reviewed
Feb 9, 2025
Yes, the doc is generated by |
The only other character that could affect it is spaces, so I can add a line to remove spaces. I don't have any other ideas. Initially, I thought about preventing SQL injection, but the input query is already an SQL statement. |
elliotxx
reviewed
Feb 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind chore
What this PR does / why we need it:
Which issue(s) this PR fixes:
#679