Skip to content

R1-004: Test compatibility and durable core paths - #220

Merged
1sgtpepper merged 1 commit into
mainfrom
r1/004-core-layer-contract-tests
Jul 22, 2026
Merged

R1-004: Test compatibility and durable core paths#220
1sgtpepper merged 1 commit into
mainfrom
r1/004-core-layer-contract-tests

Conversation

@1sgtpepper

@1sgtpepper 1sgtpepper commented Jun 27, 2026

Copy link
Copy Markdown
Owner

Summary

Adds one executable architecture contract test that runs the public compatibility path and the durable frontend/query/engine path over the same documents. It proves exact diagnostic equivalence, stable output under shuffled-equivalent input, the public AnalysisResult summary, and distinct clean, boundary, and violating cases.

Linked issue

Fixes #137.

PR Checklist

  • Linked issue checked.
  • One layer or one mechanical change.
  • Behavior/schema/golden impact checked.
  • Tests/docs updated.
  • Local checks run.
  • Keep draft until required CI is green.

Release target

R1 foundations

Single layer changed

  • Test-only architecture conformance evidence

Behavior impact

  • No user-visible behavior change

Tests and docs

  • Tests added/updated
  • No documentation change required; the architecture terms and ownership remain unchanged

Dependency checklist

  • Checked docs/contributing/pr-dependency-checks.md and updated every dependent artifact.

Local checks

pytest tests/test_architecture_contracts.py::test_pure_core_layers_execute_through_compatibility_shell_and_kernel -q
pytest -q
ruff format --check .
ruff check .
pyright
lint-imports --no-cache
python tools/architecture/terminology_drift.py --format json
mkdocs build --strict
git diff --check

All passed; the focused test passed and the full suite reported 313 passing tests. Deliberately weakening the direct-versus-compatibility equality assertion is the negative control for path drift.

@1sgtpepper
1sgtpepper marked this pull request as ready for review June 27, 2026 07:42
@1sgtpepper
1sgtpepper force-pushed the r1/004-core-layer-contract-tests branch from cc26f83 to 334be71 Compare July 22, 2026 12:01
@1sgtpepper
1sgtpepper force-pushed the r1/003-architecture-terminology-drift branch from 92d7ba8 to 0cec7bb Compare July 22, 2026 12:01
@1sgtpepper 1sgtpepper changed the title R1-004: Complete architecture contract tests for pure core layers on the durable kernel path R1-004: Test compatibility and durable core paths Jul 22, 2026
@1sgtpepper
1sgtpepper force-pushed the r1/003-architecture-terminology-drift branch from 0cec7bb to 0ce331e Compare July 22, 2026 12:07
@1sgtpepper
1sgtpepper changed the base branch from r1/003-architecture-terminology-drift to main July 22, 2026 12:08
@1sgtpepper
1sgtpepper force-pushed the r1/004-core-layer-contract-tests branch from 334be71 to 5e8d27d Compare July 22, 2026 12:08
@1sgtpepper
1sgtpepper merged commit 76955a9 into main Jul 22, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

R1-004: Complete architecture contract tests for pure core layers on the durable kernel path

1 participant