Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .apply() fail with exception #631

Open
azgabur opened this issue Feb 14, 2025 · 0 comments
Open

Make .apply() fail with exception #631

azgabur opened this issue Feb 14, 2025 · 0 comments
Labels
enhancement Improvement to existing test refactor Refactor with same functionality

Comments

@azgabur
Copy link
Contributor

azgabur commented Feb 14, 2025

Currently when doing changes to APIobject-s via the .apply() or .modify_and_apply() methods these can fail silently. This does not apply to class methods with @modify decorator as those will fail with assertion error (https://github.com/Kuadrant/testsuite/blob/main/testsuite/kubernetes/__init__.py#L90)

To fix this there are two solutions:

a) Rewrite all .apply() calls to class methods with @modify decorator
b) Override .apply() or .modify_and_apply() methods in class KubernetesObject to fail with assert if unsuccessful

@azgabur azgabur added enhancement Improvement to existing test refactor Refactor with same functionality labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing test refactor Refactor with same functionality
Projects
None yet
Development

No branches or pull requests

1 participant